-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification for milestone-maintainer post Code-Freeze (2/2) #48833
base: main
Are you sure you want to change the base?
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- THIS CONTENT IS AUTO-GENERATED via ./scripts/releng/update-release-info.sh in kubernetes/website -->
I wouldn't edit it manually.
/hold
Please edit the original first, then run the update script and propose a PR.
This change needs to land on the original page first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I missed this part.
Thanks @sftim
kubernetes/sig-release#2668 has merged /hold cancel /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the review folks! I didn't realize this was auto-generated, curious why manual edit is OK here? |
Oh! I'd thought you'd changed this to exactly align with the change to kubernetes/sig-release#2668 If not, please do an auto-update and revise the PR accordingly. |
Folks have been adding milestone to their PRs post Code-Freeze, which they shouldn't do.
We're adding documentation to discourage that behaviour.
Also updated here: kubernetes/sig-release#2668
cc @katcosgrove @fsmunoz