Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configure-dns-cluster.md #48835

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update configure-dns-cluster.md #48835

wants to merge 1 commit into from

Conversation

somnathbm
Copy link

Along with kubeadm, minikube and kind clusters also provide by default CoreDNS support

Description

Issue

Closes: #

@somnathbm
Update configure-dns-cluster.md
dbd0399 
Along with kubeadm, minikube and kind clusters also provide by default CoreDNS support
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 25, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @somnathbm!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 25, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit dbd0399
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67445f69bb836d00082156f5
😎 Deploy Preview https://deploy-preview-48835--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Ritikaa96
Ritikaa96 reviewed Dec 3, 2024
View reviewed changes
content/en/docs/tasks/access-application-cluster/configure-dns-cluster.md
@@ -5,7 +5,7 @@ content_type: concept
---

<!-- overview -->
Kubernetes offers a DNS cluster addon, which most of the supported environments enable by default. In Kubernetes version 1.11 and later, CoreDNS is recommended and is installed by default with kubeadm.
Kubernetes offers a DNS cluster addon, which most of the supported environments enable by default. In Kubernetes version 1.11 and later, CoreDNS is recommended and is installed by default with kubeadm, minikube and kind clusters as well.
Copy link
Contributor

@Ritikaa96 Ritikaa96 Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi , the coredns is installed by minikube and kind clusters but make sure the initial statement of this sentence match with the new additions.
As much as i know coredns is installed by default since minikube 0.29. Is v1.11 the default k8s version for this particular minikube version ? Please check this fine detail for kind as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as i know coredns is installed by default since minikube 0.29
Yes you're right

Is v1.11 the default k8s version for this particular minikube version ?
Well minikube v0.29 was released back in September 2018, with default stable k8s version set to v1.12.0
While kind was first released November 2018, with default stable k8s version set to v1.12.3

kind from the very beginning has default support of CoreDNS I think.
issue#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ritikaa96 Ritikaa96 Ritikaa96 left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@somnathbm @k8s-ci-robot @Ritikaa96