Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce fingerprint-based suppressions code action provider #92

Merged
merged 19 commits into from
Feb 12, 2024

Conversation

f1ames
Copy link
Contributor

@f1ames f1ames commented Feb 2, 2024

This PR adds support for fingerprint suppressions.

Fixes https://github.com/kubeshop/monokle-saas/issues/2307.
Fixes #93.
Fixes https://github.com/kubeshop/monokle-saas/issues/2438.
Fixes #94.
Fixes #76 (48a94ac).

The basic flow for when to show suppression actions:

  • When user is not logged in - show annotation-based suppressions code actions.
  • When user is logged in but local repo does not belong to any project in the cloud or belongs to a project without policy - show annotation-based suppressions code actions.
  • When user is loged in and local repo belongs to a cloud project show fingerprint-based suppressions code action:
    • If has repository write permission - show 'Suppress...' action.
    • If has repository read permission - show `Request suppression...' action.

Changes

  • Introduced fingerprint-based suppressions action.
  • Migrated to new synchronization logic - a2c092f.

Fixes

  • Simplified synchronization logic and get rid of async calls in multiple places there.

How it works

c7715ba6-ed3d-4d52-891f-971dfb7d7309.mp4

You can see an error in Monokle Cloud on suppressions view, I reported it earlier here - https://github.com/kubeshop/monokle-saas/issues/2461.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@f1ames f1ames changed the title chore: draft fingerprint suppressions code action provider [WIP] Introduce fingerprint-based suppressions code action provider Feb 8, 2024
@f1ames f1ames marked this pull request as ready for review February 8, 2024 15:40
@f1ames f1ames force-pushed the f1ames/feat/fingerprint-based-suppressions branch from 3c493fa to 7b67458 Compare February 9, 2024 10:48
@f1ames f1ames force-pushed the f1ames/feat/fingerprint-based-suppressions branch from 7b67458 to ff2f46e Compare February 9, 2024 10:59
@f1ames
Copy link
Contributor Author

f1ames commented Feb 9, 2024

I also reported - https://github.com/kubeshop/monokle-saas/issues/2464.

@f1ames
Copy link
Contributor Author

f1ames commented Feb 11, 2024

Needs kubeshop/monokle-core#605 to be released before merging this one.

@f1ames
Copy link
Contributor Author

f1ames commented Feb 11, 2024

@WitoDelnat @monojack rdy for review.

@f1ames f1ames merged commit 9d3560a into main Feb 12, 2024
3 checks passed
@f1ames f1ames deleted the f1ames/feat/fingerprint-based-suppressions branch February 12, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants