-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce fingerprint-based suppressions code action provider #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c493fa
to
7b67458
Compare
7b67458
to
ff2f46e
Compare
I also reported - https://github.com/kubeshop/monokle-saas/issues/2464. |
4 tasks
Needs kubeshop/monokle-core#605 to be released before merging this one. |
@WitoDelnat @monojack rdy for review. |
WitoDelnat
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for fingerprint suppressions.
Fixes https://github.com/kubeshop/monokle-saas/issues/2307.
Fixes #93.
Fixes https://github.com/kubeshop/monokle-saas/issues/2438.
Fixes #94.
Fixes #76 (48a94ac).
The basic flow for when to show suppression actions:
write
permission - show 'Suppress...' action.read
permission - show `Request suppression...' action.Changes
Fixes
How it works
c7715ba6-ed3d-4d52-891f-971dfb7d7309.mp4
You can see an error in Monokle Cloud on suppressions view, I reported it earlier here - https://github.com/kubeshop/monokle-saas/issues/2461.
Checklist