Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets for 2025 and fix EventTheme #293

Merged
merged 14 commits into from
Mar 25, 2025
Merged

Assets for 2025 and fix EventTheme #293

merged 14 commits into from
Mar 25, 2025

Conversation

kinoppyd
Copy link
Member

Features

  • Update seed data
  • Add 2025 assets ( ogp is a temporary placeholder)
  • Fix EventTheme attributes, remove sub_color, accent_color and text_color as they are no longer supported

@kinoppyd kinoppyd requested a review from Copilot March 25, 2025 10:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the event assets for 2025 while removing the unsupported color attributes from EventTheme. The changes include removing validations and database columns for deprecated colors, updating seed data and routes to reflect the 2025 event, and adjusting frontend styles and configuration accordingly.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
db/migrate/20250325095231_remove_useless_theme_colors.rb Removes unsupported color columns from the event_themes table
db/seeds.rb Updates event seed data to use 2025 and eliminates deprecated theme color attributes
config/routes.rb Redirects the root path from 2024 to 2025
db/seeds/schedule.yml Updates schedule events timing and keys to reflect new event dates
config/application.rb Sets the application time zone to Tokyo
app/models/event_theme.rb Removes validations for unsupported color attributes
db/schema.rb Updates schema version and removes obsolete columns
app/views/components/_app_header.html.erb Adopts CSS variable for main color in the header component
app/views/layouts/application.html.erb Removes CSS variables for the no longer supported theme colors
Comments suppressed due to low confidence (2)

db/migrate/20250325095231_remove_useless_theme_colors.rb:3

  • Consider adding a reversible migration block or explicit comments to clarify that removing these columns is intentional and irreversible, which will help during rollbacks if needed.
remove_column :event_themes, :sub_color, :string, default: "#EBE0CE"

db/seeds.rb:109

  • [nitpick] Review the fallback value 'en & ja' to ensure it matches the expected language keys; using a single default language value may help avoid ambiguity.
language: presentation['language'].then { Schedule.languages.has_key?(_1) ? _1 : "en & ja" }.downcase

@kinoppyd kinoppyd force-pushed the features/2025_data branch from 1bc4a1b to 2585979 Compare March 25, 2025 11:00
@kinoppyd kinoppyd merged commit 25b5984 into 2025 Mar 25, 2025
2 checks passed
@kinoppyd kinoppyd deleted the features/2025_data branch March 25, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant