Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VisuallyHiddenTextのわかりやすい使い方を追加 #1463

Merged
merged 8 commits into from
Dec 26, 2024
Merged

VisuallyHiddenTextのわかりやすい使い方を追加 #1463

merged 8 commits into from
Dec 26, 2024

Conversation

oremega
Copy link
Contributor

@oremega oremega commented Dec 23, 2024 •
edited
Loading

課題・背景

やったこと

VisuallyHiddenTextの使い方がわかるように以下を追加

  • ディスクリプションを変更
  • 実装例を追加
  • 使用上の注意を追加

やらなかったこと

動作確認

キャプチャ

以下からページを確認してください。
https://deploy-preview-1463--smarthr-design-system.netlify.app/products/components/visually-hidden-text/

@netlify Netlify
Copy link

netlify bot commented Dec 23, 2024 •
edited
Loading

✅ Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit 7822965
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/676d0f2947437300082fcb7a
😎 Deploy Preview https://deploy-preview-1463--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oremega oremega marked this pull request as ready for review December 23, 2024 09:37
@oremega oremega requested a review from a team as a code owner December 23, 2024 09:37
versionfive
versionfive reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@versionfive versionfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見出しやラベルが自明で、表示すると視覚的に冗長になる場合

この例がほしいな〜〜

src/content/articles/products/components/visually-hidden-text.mdx Outdated Show resolved Hide resolved
@oremega oremega requested a review from versionfive December 25, 2024 07:23
tosiiu
tosiiu reviewed Dec 25, 2024
View reviewed changes
Copy link
Contributor

@tosiiu tosiiu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

個人的な意見ですが使用上の注意があることにページを開いた段階で気付けないので、使用上の注意→実装例の順番が良いように思いました！

@oremega
Copy link
Contributor Author

oremega commented Dec 26, 2024

VisuallyHiddenTextを使っているコンポーネントの例としてまとめることにしました。
内部的にはVisuallyHiddenTextなのでpropsでも問題ないじゃろうと判断しています。

versionfive
versionfive approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@versionfive versionfive left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「VisuallyHiddenTextのわかりやすい使い方」は基本的にはなかった、というplanCということでLGTM

@oremega oremega merged commit 73f175e into main Dec 26, 2024
5 checks passed
@oremega oremega deleted the update_visually-hidden-text branch December 26, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@versionfive versionfive versionfive approved these changes

@uknmr uknmr Awaiting requested review from uknmr uknmr is a code owner automatically assigned from kufu/product-designer

@o-kwr o-kwr Awaiting requested review from o-kwr o-kwr is a code owner automatically assigned from kufu/product-designer

@drivesketch drivesketch Awaiting requested review from drivesketch

@fujitha fujitha Awaiting requested review from fujitha

@tosiiu tosiiu Awaiting requested review from tosiiu

@Qs-F Qs-F Awaiting requested review from Qs-F

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oremega @Qs-F @tosiiu @versionfive