fix: Dialog 開閉時にコンソールエラーが発生する問題を修正 #4778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-sasaki-0529
requested review from
moshisora and
nabeliwo
and removed request for
a team
s-sasaki-0529
commented
Jul 12, 2024
|
|
||
| return ( | ||
| <Transition in={isInclude} timeout={150} nodeRef={nodeRef}> | ||
| <Transition in={isInclude} timeout={150} nodeRef={wrapperRef}> |
There was a problem hiding this comment.
で nodeRef を使いましたが、このコンポーネントには既に wrapperRef があったのでそっちを使うように修正しました。
s-sasaki-0529
commented
Jul 12, 2024
| > | ||
| <div ref={nodeRef} className={styles}> | ||
| {isOpen ? children : childrenBuffer} | ||
| </div> |
There was a problem hiding this comment.
Dialog コンポーネントでも同様のエラーが発生していたのであわせて修正。
これで SmartHR UI 内の react-transition-group を使ってる箇所は全部になります。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
Overview
↑と同じ問題が Dialog コンポーネントでも起こっていたので同じ修正をする。
ついでに↑に対応漏れがあったのであわせて修正。