Slack Dialogs を Modals に移行します #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shigerix
reviewed
Aug 27, 2024
| # @param post_body [Hash] | ||
| # @see https://api.slack.com/methods/chat.postMessage | ||
| # @see https://github.com/slack-ruby/slack-ruby-client/blob/master/lib/slack/web/api/endpoints/chat.rb | ||
| def post_public_message(post_body) | ||
| @slack_api_client.chat_postMessage(post_body) | ||
| end | ||
|
|
||
| def post_direct_message(post_body) |
There was a problem hiding this comment.
ここ呼ばれていませんでしたね・・・
修正ありがとうございます！
shigerix
approved these changes
Aug 27, 2024
|
@shigerix レビューありがとうございます！ 申請ウィンドウの生成をDialogsからModalsに移行しました
|
|
確認しますね！ |
shigerix
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やりたいこと
Slack Dialogs は現在legacyな仕組みとなっており、既知の不具合もいくつかあるが今後廃止予定の為、解消される見込みがない。
不具合の一つとして、AndroidのSlackアプリでスラッシュコマンドを実行した場合に、申請ウィンドウが開かないという事象があるが、Dialogsでは上記の通りSlack側での改修予定がないとのことなので、Dialogsで作成している部分をModalsに移行したい。
やったこと
Modalsのview submissionイベントにはSlack channelのidが含まれていない為、環境変数のSLACK_CHANNELに送信するように処理を変更しましたやっていないこと
SlackModalにてrubocopのアラートが出ていますが、一旦 disableさせていただいています関連リンク