Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed frame change on in-call status bar #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bonyadmitr
Copy link

@bonyadmitr bonyadmitr commented Feb 7, 2020

it is better to implement logic on UIApplication.willChangeStatusBarFrameNotification notification for good animation, but it will take lots changes for frames. this one is hot fix and will change frame at the end of status bar animation.

It can be tested in simulator by Hardware - Toggle in-call Status bar

Screen Shot 2020-02-07 at 13 43 28

@kukushi
Copy link
Owner

kukushi commented Feb 8, 2020

@bonyadmitr Thanks for your PR. How could I reproduce this case? Using "Toggle in-call Status bar" doesn't seem to trigger the function call?

@bonyadmitr
Copy link
Author

@bonyadmitr Thanks for your PR. How could I reproduce this case? Using "Toggle in-call Status bar" doesn't seem to trigger the function call?

I'm a little bit confused. It should be called.
didChangeStatusBarFrameNotification observer must be called.
I fixed a bug in my project by this observer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants