-
Notifications
You must be signed in to change notification settings - Fork 340
feat(kuma-cp): update default policies to use new rules api instead of deprecated from #13203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…f deprecated from Signed-off-by: Marcin Skalski <[email protected]>
"mesh-timeout-all": defaultMeshTimeoutResource, | ||
"mesh-circuit-breaker-all": defaultMeshCircuitBreakerResource, | ||
"mesh-retry-all": defaultMeshRetryResource, | ||
"mesh-gateways-timeout-all-outbounds": defaultOutboundMeshGatewaysTimeoutResource, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this code, I am afraid that this is not enough as we will have duplicate timeouts, if old defaults are present.
Also, simply removing old defaults feels shady, what if someone updated defaults but left the default name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we create these resources only during mesh creation. They shouldn't be created when upgrading to the new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more issue. What about zones running older versions? These policies won't work on zones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukidzi can we protect ourselves from this? some flag on kds or something like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be possible using a KDS flag, but we would need to translate it to a compatible format at the KDS sync level. That’s a bit tricky, and the global control plane would still display the new version. Since policies are created on the global control plane and it doesn't have awareness of the zone version, it's not possible to determine how to generate the default policy correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so should we then wait until we remove support for from entirely?
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Signed-off-by: Marcin Skalski <[email protected]>
Motivation
We should update our default policies to use new api