-
Notifications
You must be signed in to change notification settings - Fork 340
test(framework): support running universal tests on remote host #13301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
…mentation Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
e6f1987
to
7223167
Compare
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of utility code that I'm a bit surprise has not been implemented anywhere else. In general I can't find anything obviously wrong anywhere. Just one Q about the pipes.
A lot of thanks to your reviewing! @slonka
Agreed, and this is the same feeling that @lahabana had. I expected there should be some existing SSH tunneling implementations at least. Well, there are such implementations, but those are either out-of-date or very small projects, I could not tell how well they are maintained (or even if they are actually maintained.) Some example projects are:
The other parts of the |
Signed-off-by: Jay Chen <[email protected]>
3472399
to
1177905
Compare
Signed-off-by: Jay Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything obviously wrong here, just the pipe thing that Jay explained.
Motivation
Support running universal tests on remote hosts
Implementation information
DockerBackend
to encapsulate calls to docker commands: the local backend executes directly, the new remote backend executes commands via an SSH tunnelkumactl
is able to access the CP ports exposed from the container running on the remote host