-
Notifications
You must be signed in to change notification settings - Fork 340
feat(helm): limit webhooks only to namespaces with kuma.io/sidecar-injection label #13378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lukasz Dziedziak <[email protected]>
…jection label Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for upgrade.md and there is definitely something that got merged badly because one point is in the middle of another
Co-authored-by: Krzysztof Słonka <[email protected]> Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Motivation
Webhooks currently use a very broad namespace selector that only excludes the
kube-system
namespace. To improve both security and performance, we’ve decided to restrict webhooks to only watch namespaces that have thekuma.io/sidecar-injection
label.Implementation information
kuma.io/sidecar-injection
, orkuma-system
(for mesh defaulter/owner reference cases).kuma.io/sidecar-injection
labelNeeds: #13377
Supporting documentation
Fix #13372