Make averageHeartRate optional
#47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvs-coder
reviewed
Jul 4, 2022
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't see the point of creating of these models, because the ECG can be generated only by Watch, so the data can be only read. By creating these enums with constructors you try to introduce and possibility to create the ECG objects here
kvs-coder
force-pushed
the
master
branch
3 times, most recently
from
76f8ed3 to
6f05fe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
There is no option to collect the voltage measurements for electrograms with inconclusive poor readings because they do not have any value for
averageHeartRate. Therefore, we should allow fornullvalue foraverageHeartRate.