feat(BA-1131): Add action_id in ActionProcessor for tracking Action
#4131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopemachine
changed the title
task_id in ActionProcessor for tracking Actiontask_id in ActionProcessor for tracking Action
github-actions
bot
added
size:S
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/ai/backend/manager/actions/processor.py:34
- Ensure that all implementations of ActionMonitor are updated to handle the new prepare method signature with the meta parameter to avoid runtime errors.
task_id = uuid.uuid4()
src/ai/backend/manager/actions/monitors/monitor.py:7
- Confirm that all ActionMonitor subclasses have been updated with the new prepare method signature, as this change might break existing implementations if not properly adjusted.
async def prepare(self, action: BaseAction, meta: BaseActionTriggerMeta) -> None:
e3940de to
b2110a5
Compare
jopemachine
changed the title
task_id in ActionProcessor for tracking Actionaction_id in ActionProcessor for tracking Action
HyeockJinKim
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4130 (BA-1131).
Checklist: (if applicable)