fix(BA-1150): Broken single image rescan on HarborRegistryV2
#4161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:XS
jopemachine
changed the title
HarborRegistryV2HarborRegistryV2
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/ai/backend/manager/container_registry/harbor.py:325
- Ensure that the 'headers' key in rqst_args is always defined to avoid a potential KeyError if it is missing. Consider using rqst_args.get("headers", {}) to safely check for the 'Accept' header.
if "Accept" in rqst_args["headers"]:
HyeockJinKim
approved these changes
Apr 14, 2025
lablup-octodog
pushed a commit
that referenced
this pull request
Apr 14, 2025
Backported-from: main (25.5) Backported-to: 24.03 Backport-of: 4161
lablup-octodog
pushed a commit
that referenced
this pull request
Apr 14, 2025
Backported-from: main (25.5) Backported-to: 23.09 Backport-of: 4161
This was referenced Apr 14, 2025
lablup-octodog
pushed a commit
that referenced
this pull request
Apr 14, 2025
Backported-from: main (25.5) Backported-to: 24.09 Backport-of: 4161
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
#4162) Co-authored-by: Gyubong Lee <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
#4164) Co-authored-by: Gyubong Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4160 (BA-1150).
Checklist: (if applicable)