Skip to content

feat(BA-1156): Customize SMTP template #4207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 17, 2025
Merged

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Apr 17, 2025

resolves #4168 (BA-1156).

Checklist: (if applicable)

  • Mention to the original issue

@github-actions github-actions bot added size:M 30~100 LoC comp:manager Related to Manager component labels Apr 17, 2025
@jopemachine jopemachine changed the title feat: Customize SMTP template feat(BA-1156): Customize SMTP template Apr 17, 2025
@jopemachine jopemachine marked this pull request as ready for review April 17, 2025 06:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for customizable SMTP email templates for the Backend.AI SMTP Reporter to resolve BA-1156. Key changes include adding a new "template" parameter to the SMTP configuration, updating the SMTPReporter to generate email bodies using the provided template, and modifying both the default configuration and sample TOML file with the new template and trigger-policy changes.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ai/backend/manager/server.py Added "template" argument when initializing the SMTPReporter configuration.
src/ai/backend/manager/reporters/smtp.py Updated SMTPReporter to build email bodies from a configurable template.
src/ai/backend/manager/config.py Introduced the default SMTP template and updated the config schema.
configs/manager/sample.toml Added the template setting and updated the trigger-policy.
changes/4207.feature.md Documented the new functionality for customizing SMTP templates.

@HyeockJinKim HyeockJinKim enabled auto-merge April 17, 2025 06:28
@HyeockJinKim HyeockJinKim added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit 8f6c696 Apr 17, 2025
25 checks passed
@HyeockJinKim HyeockJinKim deleted the feat/customize-smtp-template branch April 17, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize email body in SMTP Reporter
2 participants