Skip to content

feat(BA-1184): Add more filterspec to EndPoint GQL schema #4210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2025

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Apr 17, 2025

resolves #4209 (BA-1184).

Checklist: (if applicable)

  • Mention to the original issue

@github-actions github-actions bot added the size:S 10~30 LoC label Apr 17, 2025
@jopemachine jopemachine changed the title feat: Add more filterspec to EndPoint GQL feat(BA-1184): Add more filterspec to EndPoint GQL Apr 17, 2025
@github-actions github-actions bot added the comp:manager Related to Manager component label Apr 17, 2025
@jopemachine jopemachine force-pushed the feat/add_more_filterspec_to_endpoint branch from a7dc5aa to b6a11b8 Compare April 17, 2025 07:20
@jopemachine jopemachine marked this pull request as ready for review April 17, 2025 07:20
@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 07:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/ai/backend/manager/models/gql_models/endpoint.py:584

  • [nitpick] Consider verifying if the relative ordering of keys (e.g., 'created_at' in the filterspec versus order mapping) is intentional to ensure consistency and improve readability.
"endpoint_id": ("endpoints_id", None),

@jopemachine jopemachine changed the title feat(BA-1184): Add more filterspec to EndPoint GQL feat(BA-1184): Add more filterspec to EndPoint GQL schema Apr 17, 2025
@jopemachine jopemachine force-pushed the feat/add_more_filterspec_to_endpoint branch from 3f733b6 to c35f01e Compare April 19, 2025 01:02
@jopemachine jopemachine enabled auto-merge April 19, 2025 01:02
@jopemachine jopemachine added this pull request to the merge queue Apr 19, 2025
Merged via the queue into main with commit 4ac4431 Apr 19, 2025
28 checks passed
@jopemachine jopemachine deleted the feat/add_more_filterspec_to_endpoint branch April 19, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow query GQL endpoint list by endpoint id
1 participant