Skip to content

fix(BA-1186): VFolder clone not working #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 21, 2025
Merged

fix(BA-1186): VFolder clone not working #4214

merged 10 commits into from
Apr 21, 2025

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Apr 17, 2025

resolves #4212 (BA-1186)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@fregataa fregataa added this to the 25Q1 milestone Apr 17, 2025
@fregataa fregataa self-assigned this Apr 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the issue with cloning VFolders by ensuring the correct user record and associated policies are retrieved. The changes include switching to a new method to fetch the user with policies in vfolder cloning and adding several query helper methods and type aliases in the user model.

  • Changed user fetching in vfolder cloning to use get_user_by_id_with_policies.
  • Updated retrieval of allowed vfolder hosts from the main keypair’s resource policy.
  • Added new query helper functions, condition merging, and related fields support in the user model.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/ai/backend/manager/services/vfolder/services/vfolder.py Updates to ensure the correct user record with policies is fetched and to retrieve allowed hosts from main keypair.
src/ai/backend/manager/models/user.py New query functions and type aliases for dynamic condition merging and related field loading.
Comments suppressed due to low confidence (1)

src/ai/backend/manager/models/user.py:319

  • [nitpick] The inner function name '_by_userusername' in the by_username function is inconsistent with its purpose; consider renaming it to '_by_username' for clarity.
def _by_userusername(

@github-actions github-actions bot added size:L 100~500 LoC comp:manager Related to Manager component labels Apr 17, 2025
@jopemachine
Copy link
Member

Project vfolder cloning is still not working.

@HyeockJinKim HyeockJinKim added this pull request to the merge queue Apr 21, 2025
Merged via the queue into main with commit 61621cc Apr 21, 2025
28 checks passed
@HyeockJinKim HyeockJinKim deleted the fix/vfolder-clone branch April 21, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 Internal Server Error when cloning VFolder
3 participants