fix(BA-1187): None network deletion error when deleting session
#4219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:XS
jopemachine
changed the title
None network deletion error when deleting session
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an error where a None value for network deletion would cause an exception when deleting a session.
- Added a conditional check for a valid network reference name before attempting to delete the network.
- Updated the changelog documentation to reflect the fix.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ai/backend/manager/registry.py | Added a safeguard to prevent deletion when network_ref_name is None. |
| changes/4219.fix.md | Updated the change log to describe the fix. |
|
Closed as duplicated with #4215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4213 (BA-4219).
Checklist: (if applicable)