Add @memoize in steps.annotation #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
added
area:annotations
|
I'm not a fan of these formating rules tbh.. |
hamzaremmal
commented
Oct 3, 2024
hamzaremmal
force-pushed
the
annotation-memoize
branch
from
837bdb5 to
fc587f4
Compare
natsukagami
reviewed
Oct 8, 2024
natsukagami
reviewed
Oct 15, 2024
Comment on lines
+103
to
+108
| if $cache.contains($key) then | ||
| $cache($key) | ||
| else | ||
| val res = $rhs | ||
| $cache($key) = res | ||
| res |
There was a problem hiding this comment.
We should use $cache.getOrElseUpdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add prototype of a general use memoize annotation