expr: fix memory management #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
enh-google
reviewed
Nov 11, 2019
enh-google
reviewed
Nov 11, 2019
|
uh I did not mean to do that |
Andy Chu's patch from the mailing list, modified slightly to fit the current source. http://lists.landley.net/htdig.cgi/toybox-landley.net/2016-March/008113.html
|
(you might want to squash the two commits into one for ease of review. you probably also want to just send the patch on the list, because rob pays more attention to that than to the pull requests...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Andy Chu's patch from the mailing list, modified slightly to fit the current source.
http://lists.landley.net/htdig.cgi/toybox-landley.net/2016-March/008113.html
This fixes #147 as well as fixing all remaining memory management issues in expr from what I can see (valgrind now gives no warnings or any indication of issues while previously it reported many invalid reads).