core: Add ruff rules A (builtins shadowing) #29312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
Ɑ: core
cbornet
commented
Jan 20, 2025
| from langchain_core.messages import BaseMessage | ||
| from langchain_core.output_parsers.transform import BaseTransformOutputParser | ||
|
|
||
| T = TypeVar("T") | ||
|
|
||
|
|
||
| def droplastn(iter: Iterator[T], n: int) -> Iterator[T]: | ||
| def _droplastn(iterator: Iterator[T], n: int) -> Iterator[T]: |
There was a problem hiding this comment.
Is it OK to consider droplastn private ?
There was a problem hiding this comment.
I generally suggest avoiding doing so unless there's a good reason -- we didn't have an official policy about the public interface, so it's hard to know what user code might be relying on, and unclear that there's a good reason to risk breaking some users code
There was a problem hiding this comment.
OK. I understand.
As a user though, I would really not use a function from output_parsers.list in my own code...
There was a problem hiding this comment.
I rolled back. PTAL.
There was a problem hiding this comment.
Hi @eyurtsev could you take another look ?
cbornet
force-pushed
the
ruff-core-a
branch
5 times, most recently
from
ed51615 to
298117c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.astral.sh/ruff/rules/#flake8-builtins-a
noqawhere backward compatibility was needed@overridewhen applicable