fix(core): Fix issue in .d.ts typing for TextEncoder #7726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7247 without loosing the typing
This pull request makes a small but important change to the
BytesOutputParser
class in thelangchain-core
package. The change involves updating the type of thetextEncoder
property to use a more specific type.globalThis.TextEncoder
(when not imported fromnode:util
) is a value, not a type. In this case, the type is actuallyInstanceType<typeof TextEncoder>
.langchain-core/src/output_parsers/bytes.ts
: Updated thetextEncoder
property to useInstanceType<typeof TextEncoder>
instead ofany
for better type safety.