-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Dylan/quick actions animations + UI #310
base: main
Are you sure you want to change the base?
Conversation
@starmorph is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seeing some issues with the selected state for custom quick actions
- when i submit an action, it doesn't reset the tool bar state, so when I open it again it shows the selected quick action as selected still. ideally these states reset if the quick action toolbar collapses/an action is submitted.
- im also seeing some cases where i click on an action which requires the double "click to confirm", but it instead sends the request right away. see loom (I only clicked the fix bugs icon once in this video) also some other weird stuff is happening around the expanded/collapsed state.
other nits:
- the "confirm" step when a user clicks the icon should ideally be an arrow like in ChatGPT, instead of the same icon with inverted colors. imo this UX is a little more clear to the user that clicking again will actually execute the task.
- for the actions which are nested (e.g changing languages, reading level, etc), these should also require the click to confirm. see this loom showing how ChatGPT does it for the text length slider
Other than that, the animations are much better now! Thanks for this
Here's a PR summary of the changes made to the quick actions toolbar:
Quick Actions Toolbar Enhancements
Loom Overview
Overview
This PR introduces several improvements to the quick actions toolbar, focusing on enhanced animations, better user interaction, and consistent styling across both code and text toolbars.
Key Changes
1. Animation Improvements
2. Toolbar Behavior
3. UI Enhancements
4. Component-Specific Improvements
Length Options
Reading Level Options
Translate Options
5. Technical Improvements
Animation Parameters
Testing Notes
Future Considerations
This PR significantly improves the user experience of the quick actions toolbar by making it more responsive, visually appealing, and consistent across different contexts.