Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Dylan/canvas-expansion #311

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Draft] Dylan/canvas-expansion #311

wants to merge 5 commits into from

Conversation

starmorph
Copy link

  • Update Canvas to only open on artifact generation. otherwise for simple text message it stays in default chat mode.
  • Created Artifact rendering loading state component + animation for transitioning from chat to canvas/artifact editor state

Loom Video

@vercel Vercel
Copy link

vercel bot commented Mar 16, 2025

@starmorph is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-canvas ❌ Failed (Inspect) Mar 18, 2025 1:13am

bracesproul
bracesproul requested changes Mar 18, 2025
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i really like this ui improvement! My one nit is the initial loading state should only be shown until the first "token" from the artifact is generated, then it should show the artifact streaming in. The way you have it right now is it'll show the artifact loading state for the entire duration of the initial artifact generation.

Other than that, lgtm!

apps/web/src/contexts/GraphContext.tsx
@@ -468,6 +471,7 @@ export function GraphProvider({ children }: { children: ReactNode }) {
}

if (langgraphNode === "generateArtifact") {
setCurrentNode("generateArtifact");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be better to define this on ~L423 after the langgraphNode is extracted so it always has the proper node in the state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@starmorph @bracesproul