docs: fix broken link #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jannikmaierhoefer is attempting to deploy a commit to the langfuse Team on Vercel. A member of the Team first needs to authorize it. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| @@ -20,7 +20,7 @@ Modular mono repo for the Langfuse JS/TS client libraries. | |||
| | [langfuse](./langfuse) | [](https://www.npmjs.com/package/langfuse) | Node >= 18, Web, Edge | | |||
| | [langfuse-node](./langfuse-node) | [](https://www.npmjs.com/package/langfuse-node) | Node < 18 | | |||
| | [langfuse-langchain](./langfuse-langchain) | [](https://www.npmjs.com/package/langfuse-langchain) | Node >= 20, Web, Edge | | |||
| | [langfuse-vercel (beta)](./langfuse-vercel) | [](https://www.npmjs.com/package/langfuse-vercel) | Node >= 20, Web, Edge | | |||
| | [langfuse-vercel (beta)](/modules/langfuse_vercel.html) | [](https://www.npmjs.com/package/langfuse-vercel) | Node >= 20, Web, Edge | | |||
There was a problem hiding this comment.
The link to langfuse-vercel (beta) was changed from a relative path to an absolute path. This is inconsistent with the other package links which use relative paths. Consider reverting to a relative path for consistency unless there's a specific reason for this change.
Suggested change
| | [langfuse-vercel (beta)](/modules/langfuse_vercel.html) | [](https://www.npmjs.com/package/langfuse-vercel) | Node >= 20, Web, Edge | | |
| | [langfuse-vercel (beta)](./modules/langfuse_vercel.html) | [](https://www.npmjs.com/package/langfuse-vercel) | Node >= 20, Web, Edge | |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
Fixed broken link in README.md for the langfuse-vercel package documentation by changing from relative to absolute path.
- Changed link from
./langfuse-vercelto/modules/langfuse_vercel.htmlin/README.mdpackage table - New absolute path
/modules/langfuse_vercel.htmlneeds verification as it may not match repository structure - Consider using relative path to
langfuse-vercel/README.mdfor consistency with other package links
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -20,7 +20,7 @@ Modular mono repo for the Langfuse JS/TS client libraries. | |||
| | [langfuse](./langfuse) | [](https://www.npmjs.com/package/langfuse) | Node >= 18, Web, Edge | | |||
| | [langfuse-node](./langfuse-node) | [](https://www.npmjs.com/package/langfuse-node) | Node < 18 | | |||
| | [langfuse-langchain](./langfuse-langchain) | [](https://www.npmjs.com/package/langfuse-langchain) | Node >= 20, Web, Edge | | |||
| | [langfuse-vercel (beta)](./langfuse-vercel) | [](https://www.npmjs.com/package/langfuse-vercel) | Node >= 20, Web, Edge | | |||
| | [langfuse-vercel (beta)](/modules/langfuse_vercel.html) | [](https://www.npmjs.com/package/langfuse-vercel) | Node >= 20, Web, Edge | | |||
There was a problem hiding this comment.
logic: The absolute path '/modules/langfuse_vercel.html' may not be correct. Consider using a full URL to the documentation site or keeping it as a relative link to the repository directory if it exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hassiebp, this link was broken. Not quite sure why because it looked right. This change should work - lgfy?
Important
Fix broken link for
langfuse-vercelpackage inREADME.md.langfuse-vercelpackage inREADME.mdfrom./langfuse-vercelto/modules/langfuse_vercel.html.This description was created by
for 8c8ba00. It will automatically update as commits are pushed.