WIP: Command for generation failed_jobs table migration #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Command should replace default "queue:failed-table" Laravel command
that generates table where is failed queue tasks saved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Please review this idea of providing new command
doctrine:migrations:queue-failed-tablethat should replace the defaultqueue:failed-table.Command generates migration for creation of
failed_jobsused by the internal Laravel Queue package.We have the FailedJobsServiceProvider in the ORM package, but have very serious downside as it's running query that checks if table exists on each job processing. Some jobs may not need connection to DB, it may slow down job tasks execution.
Basically the perfect case for the
failed_jobstable to be generated once.I suggest this solution for the problem.