Add typing to HasFactory the Laravel way #748
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MONDESIR Malik <[email protected]>
|
When I cloned the repo and ran I had to revert the changes and just focus on my pull request or else I'd have a messy commit. |
Signed-off-by: MONDESIR Malik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, looks like I was beat to it regarding this commit.
Context: I'm currently working on a project that uses Laravel's React Starter Kit and I found myself having to customize some stubs and generators more than I thought I would.
Like your last commit and this one, I will create some pull requests that aligns more with Laravel's new starter kits and the way
php artisan make:modelcreates files.