Fix nil pointer issue #322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 1, when no record is found during processing,
"process_#{column}_upload=" is called on it anyway, causing a nil
pointer exception. In previous versions the record was just ignored.
This restores that behaviour.
|
@lardawge currently an issue for us in production, appreciate if you could take a look 😄 Thanks for your hard work on this gem! |
|
Would there be use cases where raising an error would be a desired outcome? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 1, when no record is found during processing, "process_#{column}_upload=" is called on it anyway, causing a nil pointer exception. In previous versions the record was just ignored. This restores that behaviour.