Convert sunSafePoint to adapter #427
Open
+734
−596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahkiner
force-pushed
the
feature/426_sun_safe_point_adapter
branch
from
23bfccf to
63ddd53
Compare
leahkiner
force-pushed
the
feature/426_sun_safe_point_adapter
branch
3 times, most recently
from
330c8c4 to
d199c16
Compare
leahkiner
force-pushed
the
feature/426_sun_safe_point_adapter
branch
from
d199c16 to
3ef6bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To enable easy relocation of fsw algorithms use the adapter pattern for
sunSafePoint.This allows for relocation of fsw algorithms and then inclusion of bsk modules in any language with a c ffi/abi.
The first commit renames the C module (currently named sunSafePoint) to sunSafePoint_C and the C++ module (currently named sunSafePointCpp) to sunSafePoint. The second commit replaces the unit vector check for the
sHatBdyCmdvector. Removing the check from theresetmethod, the provided unit vector is instead normalized to a unit vector in the setter. An assert statement checks that the given vector is not zero. The third commit converts the module to the adapter pattern.Verification
The unit test is checked to pass with these changes.
Documentation
N/A
Future work
N/A