chore: now utilizes FDv2 basis param and supports FDv1 fallback #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates, and FDv2 DataSource impls.
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
tanderson-ld
changed the title
tanderson-ld
commented
May 13, 2025
| @@ -47,7 +47,7 @@ | |||
| "dependencies": { | |||
| "@launchdarkly/js-server-sdk-common": "2.15.1", | |||
| "https-proxy-agent": "^5.0.1", | |||
| "launchdarkly-eventsource": "2.1.0" | |||
| "launchdarkly-eventsource": "2.2.0" | |||
There was a problem hiding this comment.
For reviewers: This includes error header support needed for FDv2 fallback.
tanderson-ld
commented
May 13, 2025
| @@ -25,7 +25,7 @@ it('it sets basis to true when intent code is xfer-full', () => { | |||
| }); | |||
|
|
|||
| mockStream.simulateEvent('server-intent', { | |||
| data: '{"payloads": [{"code": "xfer-full", "id": "mockId"}]}', | |||
| data: '{"payloads": [{"intentCode": "xfer-full", "id": "mockId"}]}', | |||
There was a problem hiding this comment.
FDv2 spec change.
kinyoklion
reviewed
May 15, 2025
kinyoklion
reviewed
May 15, 2025
packages/shared/sdk-server/src/store/TransactionalFeatureStore.ts
Outdated
Show resolved
Hide resolved
added 4 commits
May 19, 2025 16:21
…ecuting in parallel
kinyoklion
reviewed
May 20, 2025
packages/shared/sdk-server/src/data_sources/PollingProcessorFDv2.ts
Outdated
Show resolved
Hide resolved
kinyoklion
reviewed
May 20, 2025
kinyoklion
reviewed
May 20, 2025
packages/shared/sdk-server/src/data_sources/PollingProcessorFDv2.ts
Outdated
Show resolved
Hide resolved
kinyoklion
reviewed
May 20, 2025
packages/shared/sdk-server/src/data_sources/PollingProcessorFDv2.ts
Outdated
Show resolved
Hide resolved
kinyoklion
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.