chore: now utilizes FDv2 basis param and supports FDv1 fallback #849
Conversation
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
tanderson-ld
changed the title
| @@ -47,7 +47,7 @@ | |||
| "dependencies": { | |||
| "@launchdarkly/js-server-sdk-common": "2.15.1", | |||
| "https-proxy-agent": "^5.0.1", | |||
| "launchdarkly-eventsource": "2.1.0" | |||
| "launchdarkly-eventsource": "2.2.0" | |||
There was a problem hiding this comment.
For reviewers: This includes error header support needed for FDv2 fallback.
| @@ -25,7 +25,7 @@ it('it sets basis to true when intent code is xfer-full', () => { | |||
| }); | |||
|
|
|||
| mockStream.simulateEvent('server-intent', { | |||
| data: '{"payloads": [{"code": "xfer-full", "id": "mockId"}]}', | |||
| data: '{"payloads": [{"intentCode": "xfer-full", "id": "mockId"}]}', | |||
There was a problem hiding this comment.
FDv2 spec change.
|
Do not merge into target branch until target merges to main. |
| @@ -134,4 +134,5 @@ export interface Requests { | |||
| export interface HttpErrorResponse { | |||
| message: string; | |||
| status?: number; | |||
| headers?: Record<string, string>; | |||
There was a problem hiding this comment.
In the case of multiple values for a header is the second string some delimited form?
| Object.entries(data).forEach(([namespace, items]) => { | ||
| Object.keys(items || {}).forEach((key) => { | ||
| const item = items[key]; | ||
| promises.push( |
There was a problem hiding this comment.
We will want to do some validation tests with real stores for this behavior.
No description provided.