chore: experimental FDv2 configuration hooked up #853
Conversation
tanderson-ld
changed the title
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
| if (this._initPhaseActive && this._initFactories.pos() >= this._initFactories.length()) { | ||
| this._initPhaseActive = false; | ||
| this._syncFactories.reset(); | ||
| } |
There was a problem hiding this comment.
For reviewers: Bugfix found during testing with intermittent wifi. Error in last initializer was not leading to fallback to synchronizer.
| @@ -93,17 +105,19 @@ const VARIATION_METHOD_DETAIL_NAME = 'LDClient.variationDetail'; | |||
| export default class LDClientImpl implements LDClient { | |||
| private _initState: InitState = InitState.Initializing; | |||
|
|
|||
| private _featureStore: LDFeatureStore; | |||
| private _featureStore!: LDFeatureStore | LDTransactionalFeatureStore; | |||
There was a problem hiding this comment.
For reviewers: The !s added to various members is due to the usage of initializing functions inside the constructor and TS linter not recognizing all paths set those values. Alan and I tried use local function to work around it, but that didn't work either. Perhaps @kinyoklion , you have some ideas?
There was a problem hiding this comment.
For Reviewers: These changes have never been reviewed before, please review thoroughly.
There was a problem hiding this comment.
For reviewers: These changes have been reviewed before EXCEPT for "experimental commenting".
There was a problem hiding this comment.
For reviewers: These changes have been reviewed before EXCEPT it has been modified to not adapt FDv1 configuration to the FDv2 data system.
| dsErrors.forEach((error) => { | ||
| this.logger?.warn(error); | ||
| }); | ||
| } |
There was a problem hiding this comment.
For reviewers: When this code was previously reviewed when merging to the FDv2 holding branch, there was an else block here that would map the FDv1 options to an FDv2 dataSystem. That has been removed to have FDv1 and FDv2 not have code overlap/separability.
|
Do not merge into target branch until target merges to main. |
Requirements
This PR adds new changes to LdClientImpl to utilize FDv2 as an experimental feature.
This PR also moves changes for FDv2 from the temporary holding branch to main.