feat(icons): Add share icon
#1665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 29f5526 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
Size Change: 0 B Total Size: 522 kB ℹ️ View Unchanged
|
bradsimantel
approved these changes
May 6, 2025
matthewferry
requested changes
May 6, 2025
packages/icons/src/img/sprite.svg
Outdated
| </symbol> | ||
| </defs> | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" viewBox="0 0 20 20" fill="none"> | ||
| <path fill-rule="evenodd" clip-rule="evenodd" d="M15.1611 1.75391C15.9644 1.79375 16.7264 2.13074 17.2979 2.70215C17.9073 3.31164 18.25 4.13805 18.25 5L18.2461 5.16113C18.2063 5.96442 17.8693 6.72644 17.2979 7.29785C16.6884 7.90734 15.862 8.25 15 8.25C14.138 8.25 13.3116 7.90734 12.7021 7.29785C12.6266 7.22235 12.5555 7.14334 12.4883 7.06152L8.16895 9.28613C8.22138 9.51872 8.25 9.75778 8.25 10C8.25 10.2416 8.22111 10.4799 8.16895 10.7119L12.4883 12.9375C12.5553 12.8559 12.6268 12.7775 12.7021 12.7021C13.3116 12.0927 14.138 11.75 15 11.75C15.862 11.75 16.6884 12.0927 17.2979 12.7021C17.9073 13.3116 18.25 14.138 18.25 15L18.2461 15.1611C18.2063 15.9644 17.8693 16.7264 17.2979 17.2979C16.7264 17.8693 15.9644 18.2063 15.1611 18.2461L15 18.25C14.138 18.25 13.3116 17.9073 12.7021 17.2979C12.0927 16.6884 11.75 15.862 11.75 15C11.75 14.7579 11.7777 14.5187 11.8301 14.2861L7.51074 12.0615C7.44369 12.1432 7.37321 12.2225 7.29785 12.2979C6.68836 12.9073 5.86195 13.25 5 13.25C4.13805 13.25 3.31164 12.9073 2.70215 12.2979C2.13074 11.7264 1.79375 10.9644 1.75391 10.1611L1.75 10C1.75 9.13805 2.09266 8.31164 2.70215 7.70215C3.31164 7.09266 4.13805 6.75 5 6.75C5.86195 6.75 6.68836 7.09266 7.29785 7.70215C7.37303 7.77733 7.44383 7.85606 7.51074 7.9375L11.8301 5.71191C11.7779 5.47998 11.75 5.2415 11.75 5C11.75 4.13805 12.0927 3.31164 12.7021 2.70215C13.3116 2.09266 14.138 1.75 15 1.75L15.1611 1.75391ZM15 13.25C14.5359 13.25 14.0909 13.4345 13.7627 13.7627C13.6311 13.8943 13.5232 14.0451 13.4404 14.208C13.4331 14.2253 13.4257 14.2428 13.417 14.2598C13.4158 14.2622 13.4134 14.2642 13.4121 14.2666C13.3068 14.4945 13.25 14.7441 13.25 15C13.25 15.4641 13.4345 15.9091 13.7627 16.2373C14.0909 16.5655 14.5359 16.75 15 16.75L15.1729 16.7412C15.5735 16.7015 15.9501 16.5245 16.2373 16.2373C16.5655 15.9091 16.75 15.4641 16.75 15L16.7412 14.8271C16.7015 14.4265 16.5245 14.0499 16.2373 13.7627C15.9091 13.4345 15.4641 13.25 15 13.25ZM5 8.25C4.53587 8.25 4.09088 8.43451 3.7627 8.7627C3.43451 9.09088 3.25 9.53587 3.25 10L3.25879 10.1729C3.29855 10.5735 3.47551 10.9501 3.7627 11.2373C4.09088 11.5655 4.53587 11.75 5 11.75C5.46413 11.75 5.90912 11.5655 6.2373 11.2373C6.37902 11.0956 6.4923 10.9313 6.57715 10.7539C6.57941 10.7493 6.58064 10.7439 6.58301 10.7393C6.58434 10.7367 6.58555 10.734 6.58691 10.7314C6.69184 10.5039 6.75 10.2554 6.75 10C6.75 9.74297 6.69218 9.49238 6.58594 9.26367L6.58301 9.25977C6.57427 9.24277 6.5669 9.22533 6.55957 9.20801C6.4768 9.04509 6.36894 8.89433 6.2373 8.7627C5.90912 8.43451 5.46413 8.25 5 8.25ZM15 3.25C14.5359 3.25 14.0909 3.43451 13.7627 3.7627C13.4345 4.09088 13.25 4.53587 13.25 5C13.25 5.25302 13.3061 5.49976 13.4092 5.72559C13.4117 5.73019 13.4146 5.73458 13.417 5.73926C13.4239 5.75258 13.4296 5.76675 13.4355 5.78027C13.519 5.94754 13.628 6.10263 13.7627 6.2373C14.0909 6.56549 14.5359 6.75 15 6.75C15.4641 6.75 15.9091 6.56549 16.2373 6.2373C16.5655 5.90912 16.75 5.46413 16.75 5L16.7412 4.82715C16.7015 4.4265 16.5245 4.04988 16.2373 3.7627C15.9501 3.47551 15.5735 3.29855 15.1729 3.25879L15 3.25Z" fill="#3F454C" style="fill:#3F454C;fill:color(display-p3 0.2471 0.2706 0.2980);fill-opacity:1;"/> |
There was a problem hiding this comment.
You need to add the paths here to this sprite. the current diff deletes all the icons in the sprite. instead, you want to only add your new icon (preferably in alphabetical order) to the sprite sheet:
<symbol viewBox="0 0 20 20" id="lp-icon-share">
<path
fill-rule="evenodd"
d="M15.1611 1.75391C15.9644 1.79375 16.7264 2.13074 17.2979 2.70215C17.9073 3.31164 18.25 4.13805 18.25 5L18.2461 5.16113C18.2063 5.96442 17.8693 6.72644 17.2979 7.29785C16.6884 7.90734 15.862 8.25 15 8.25C14.138 8.25 13.3116 7.90734 12.7021 7.29785C12.6266 7.22235 12.5555 7.14334 12.4883 7.06152L8.16895 9.28613C8.22138 9.51872 8.25 9.75778 8.25 10C8.25 10.2416 8.22111 10.4799 8.16895 10.7119L12.4883 12.9375C12.5553 12.8559 12.6268 12.7775 12.7021 12.7021C13.3116 12.0927 14.138 11.75 15 11.75C15.862 11.75 16.6884 12.0927 17.2979 12.7021C17.9073 13.3116 18.25 14.138 18.25 15L18.2461 15.1611C18.2063 15.9644 17.8693 16.7264 17.2979 17.2979C16.7264 17.8693 15.9644 18.2063 15.1611 18.2461L15 18.25C14.138 18.25 13.3116 17.9073 12.7021 17.2979C12.0927 16.6884 11.75 15.862 11.75 15C11.75 14.7579 11.7777 14.5187 11.8301 14.2861L7.51074 12.0615C7.44369 12.1432 7.37321 12.2225 7.29785 12.2979C6.68836 12.9073 5.86195 13.25 5 13.25C4.13805 13.25 3.31164 12.9073 2.70215 12.2979C2.13074 11.7264 1.79375 10.9644 1.75391 10.1611L1.75 10C1.75 9.13805 2.09266 8.31164 2.70215 7.70215C3.31164 7.09266 4.13805 6.75 5 6.75C5.86195 6.75 6.68836 7.09266 7.29785 7.70215C7.37303 7.77733 7.44383 7.85606 7.51074 7.9375L11.8301 5.71191C11.7779 5.47998 11.75 5.2415 11.75 5C11.75 4.13805 12.0927 3.31164 12.7021 2.70215C13.3116 2.09266 14.138 1.75 15 1.75L15.1611 1.75391ZM15 13.25C14.5359 13.25 14.0909 13.4345 13.7627 13.7627C13.6311 13.8943 13.5232 14.0451 13.4404 14.208C13.4331 14.2253 13.4257 14.2428 13.417 14.2598C13.4158 14.2622 13.4134 14.2642 13.4121 14.2666C13.3068 14.4945 13.25 14.7441 13.25 15C13.25 15.4641 13.4345 15.9091 13.7627 16.2373C14.0909 16.5655 14.5359 16.75 15 16.75L15.1729 16.7412C15.5735 16.7015 15.9501 16.5245 16.2373 16.2373C16.5655 15.9091 16.75 15.4641 16.75 15L16.7412 14.8271C16.7015 14.4265 16.5245 14.0499 16.2373 13.7627C15.9091 13.4345 15.4641 13.25 15 13.25ZM5 8.25C4.53587 8.25 4.09088 8.43451 3.7627 8.7627C3.43451 9.09088 3.25 9.53587 3.25 10L3.25879 10.1729C3.29855 10.5735 3.47551 10.9501 3.7627 11.2373C4.09088 11.5655 4.53587 11.75 5 11.75C5.46413 11.75 5.90912 11.5655 6.2373 11.2373C6.37902 11.0956 6.4923 10.9313 6.57715 10.7539C6.57941 10.7493 6.58064 10.7439 6.58301 10.7393C6.58434 10.7367 6.58555 10.734 6.58691 10.7314C6.69184 10.5039 6.75 10.2554 6.75 10C6.75 9.74297 6.69218 9.49238 6.58594 9.26367L6.58301 9.25977C6.57427 9.24277 6.5669 9.22533 6.55957 9.20801C6.4768 9.04509 6.36894 8.89433 6.2373 8.7627C5.90912 8.43451 5.46413 8.25 5 8.25ZM15 3.25C14.5359 3.25 14.0909 3.43451 13.7627 3.7627C13.4345 4.09088 13.25 4.53587 13.25 5C13.25 5.25302 13.3061 5.49976 13.4092 5.72559C13.4117 5.73019 13.4146 5.73458 13.417 5.73926C13.4239 5.75258 13.4296 5.76675 13.4355 5.78027C13.519 5.94754 13.628 6.10263 13.7627 6.2373C14.0909 6.56549 14.5359 6.75 15 6.75C15.4641 6.75 15.9091 6.56549 16.2373 6.2373C16.5655 5.90912 16.75 5.46413 16.75 5L16.7412 4.82715C16.7015 4.4265 16.5245 4.04988 16.2373 3.7627C15.9501 3.47551 15.5735 3.29855 15.1729 3.25879L15 3.25Z"
clip-rule="evenodd"
/>
</symbol>
note: all fills should be removed. only supply paths
matthewferry
reviewed
May 6, 2025
| @@ -1882,6 +1882,13 @@ | |||
| clip-rule="evenodd" | |||
| /> | |||
| </symbol> | |||
| <symbol viewBox="0 0 20 20" id="lp-icon-share"> | |||
There was a problem hiding this comment.
@rapha-ld just fyi, this is how you'd add the paths in future
matthewferry
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding share icon for Feature Monitoring dashboard
Screenshots (if appropriate):