Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve workflow #11464

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

ci: improve workflow #11464

wants to merge 1 commit into from

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Dec 3, 2024

  1. Run tests, iff the other prerequisites are met
  2. In case of a translation PR, skip tests not related to translations (and building the apps)

I've optimized the ci workflow a bit:

First of all the tests were run, even if lints and other prereqs failed. Thus I moved the tests down in the workflow.
There is also no need to run the entire workflow when a translation PR is submitted. The pipelines run for a long time. We can save not only time but CPU cycles in gh actions.

1. Run tests, iff the other prerequisites are met
2. In case of a translation PR, skip tests not related to translations
@laurent22
Copy link
Owner

Isn't it possible to do this based on the list of committed files? If there's just one .po file we run the translation tests and exit, otherwise we run everything. With a regex on the PR title I could see it match when it shouldn't and not match when it should

@tessus
Copy link
Collaborator Author

tessus commented Dec 4, 2024

This is a good question. I am not sure if I can get the list of changed/added files of a PR.

I was a bit concerned about the regex as well, but I checked the current commit messages and made sure that just because language is in there, the regex won't match. It must include either .po with a space after it or at the end of the message, include translation, or include language (with add, fix, update in front of it, with an optional language name in between). I have run a lot of manual tests and while it is possible that there are false negatives, the chances are very low.
There could also be false positives when checking for .po files in the list of changes, unless we check, whether only files with a .po extension were changed/added.

I can try to find out if it is possible to do so via gh actions. I am more than happy to get any help as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants