Mobile: Fixes #9322: Fix editor scrollbar on iOS #9531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
personalizedrefrigerator
changed the title
| @@ -150,6 +153,7 @@ const ExtendedWebView = (props: Props, ref: Ref<WebViewControl>) => { | |||
| onMessage={props.onMessage} | |||
| onError={props.onError} | |||
| onLoadEnd={props.onLoadEnd} | |||
| decelerationRate='normal' | |||
There was a problem hiding this comment.
This fixes the "scroll feels non-native" issue we were previously experiencing when using the WebView top-level scroll.
This should also allow removing some iOS-specific viewer CSS that was added to work around this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses the
rootelement as the scrolling element, rather than CodeMirror's internal scroller on mobile.It seems that the scrollbar-related bug does not occur when the root document element is used to scroll.
Fixes #9322.
Testing
This has been tested on an iOS 17.0 simulator and a physical iOS 17.2 device.