SolidJS and Vite Migration #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented migration from Next.js to fully client-side Solid.js for performance and lighter bundle size. Speednote is a PWA, so technically server-rendered components are not that necessary.
Properly utilized ESLint and Prettier with more declarative configuration and regular expressions.
Migrated the bundler to use Vite so that it supports SolidJS out of the box. It's much faster and less overkill compared to Webpack.
Behavior
Some Zod schemas are simplified and utilizing
createStoreto store a complex object.Tests
Removes the mocks caused by Next.js dependencies, and utilizes more "natural mocks" which are caused by JSDOM's limitations.
Issue
Resolves #24.