feat: upgrade to cosmos v50 #1833

Yaroms · 2024-12-12T14:22:08Z

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

read the contribution guide
included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the main branch
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

This reverts commit 6b55d8c.

github-actions · 2024-12-15T15:02:40Z

Test Results

2 391 tests +5 2 390 ✅ +4 14m 43s ⏱️ - 10m 25s
121 suites - 1 0 💤 ±0
7 files ±0 0 ❌ ±0 1 🔥 +1

For more details on these errors, see this check.

Results for commit 18a9c09. ± Comparison against base commit 0284c25.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.

github.com/lavanet/lava/v4/x/pairing/keeper ‑ TestGetPairing/epochTimesChanged

github.com/lavanet/lava/v4/utils/lavaslices ‑ TestSortStable
github.com/lavanet/lava/v4/utils/lavaslices ‑ TestSortStable/already_sorted
github.com/lavanet/lava/v4/utils/lavaslices ‑ TestSortStable/duplicates
github.com/lavanet/lava/v4/utils/lavaslices ‑ TestSortStable/empty_slice
github.com/lavanet/lava/v4/utils/lavaslices ‑ TestSortStable/negative_numbers
github.com/lavanet/lava/v4/utils/lavaslices ‑ TestSortStable/reverse_order

♻️ This comment has been updated with latest results.

This reverts commit 67c7f0b.

…CNS-cosmos-50-upgrade

This reverts commit 98fcb54.

oren-lava · 2025-01-28T11:43:39Z

app/encoding.go

@@ -29,7 +28,7 @@ func MakeEncodingConfig() params.EncodingConfig {
 	encodingConfig := makeEncodingConfig()
 	std.RegisterLegacyAminoCodec(encodingConfig.Amino)
 	std.RegisterInterfaces(encodingConfig.InterfaceRegistry)
-	ModuleBasics.RegisterLegacyAminoCodec(encodingConfig.Amino)
+	// ModuleBasics.RegisterLegacyAminoCodec(encodingConfig.Amino)


remove comment

oren-lava · 2025-01-28T11:46:01Z

app/export.go

 	if err != nil {
 		return servertypes.ExportedApp{}, err
 	}
+
+	validators, err := staking.WriteValidators(ctx, app.StakingKeeper)


check error and return in err != nil instead of returning the error

oren-lava · 2025-01-28T12:29:12Z

protocol/rpcprovider/rewardserver/reward_server.go

-		if len(splittedAttrs) > 1 {
-			var err error
-			index, err = strconv.Atoi(splittedAttrs[1])
+		if len(splittedAttrs) == 2 {


put a comment specifying that you check for 2 because in cosmos 50 you have msg_index

oren-lava · 2025-01-28T13:10:12Z

protocol/statetracker/events.go

@@ -71,7 +71,7 @@ func eventsLookup(ctx context.Context, clientCtx client.Context, blocks, fromBlo
 				utils.LavaFormatError("invalid blockResults status", err)
 				return
 			}
-			for _, event := range blockResults.BeginBlockEvents {
+			for _, event := range blockResults.FinalizeBlockEvents {


check mode=BeginBlock (see EndBlockEvents)

oren-lava · 2025-01-28T13:10:30Z

protocol/statetracker/updaters/event_tracker.go

@@ -101,7 +101,7 @@ func (et *EventTracker) getLatestVersionEvents(latestBlock int64) (updated bool,
 	if et.latestUpdatedBlock != latestBlock {
 		return false, utils.LavaFormatWarning("event results are different than expected", nil, utils.Attribute{Key: "requested latestBlock", Value: latestBlock}, utils.Attribute{Key: "current latestBlock", Value: et.latestUpdatedBlock})
 	}
-	for _, event := range et.blockResults.EndBlockEvents {
+	for _, event := range et.blockResults.FinalizeBlockEvents {


check mode=EndBlock (see EndBlockEvents)

oren-lava · 2025-01-28T14:30:40Z

x/rewards/keeper/providers.go


-	return nil
+	return k.distributionKeeper.SetFeePool(ctx, feePool)


handle the error before returning and print a informative message (like "failed funding community pool")

oren-lava · 2025-01-28T14:37:19Z

x/spec/module.go

@@ -131,7 +134,13 @@ func (am AppModule) RegisterServices(cfg module.Configurator) {
 	migrator := keeper.NewMigrator(am.keeper)

 	// register v3 -> v4 migration
-	if err := cfg.RegisterMigration(types.ModuleName, 3, migrator.Migrate3to4); err != nil {
+	// if err := cfg.RegisterMigration(types.ModuleName, 3, migrator.Migrate3to4); err != nil {


remove comment

oren-lava · 2025-01-28T14:50:22Z

app/app.go

-		upgradeclient.LegacyCancelProposalHandler,
-		ibcclientclient.UpdateClientProposalHandler,
-		ibcclientclient.UpgradeProposalHandler,
+		// UNFORKING v2 TODO: Verify it is okay to remove these


do the todo

oren-lava · 2025-01-28T15:15:39Z

app/app.go

-		AddRoute(upgradetypes.RouterKey, upgrade.NewSoftwareUpgradeProposalHandler(&app.UpgradeKeeper)).
-		// AddRoute(ibcexported.RouterKey, ibcclient.NewClientProposalHandler(app.IBCKeeper.ClientKeeper))
-		AddRoute(ibcclienttypes.RouterKey, ibcclient.NewClientProposalHandler(app.IBCKeeper.ClientKeeper))
+	// TODO check all these proposals still work YAROM


do the todo

oren-lava · 2025-01-28T15:31:37Z

app/app.go

@@ -1079,17 +1132,21 @@ func GetMaccPerms() map[string][]string {
 func initParamsKeeper(appCodec codec.BinaryCodec, legacyAmino *codec.LegacyAmino, key, tkey storetypes.StoreKey) paramskeeper.Keeper {
 	paramsKeeper := paramskeeper.NewKeeper(appCodec, legacyAmino, key, tkey)

+	// legacy param set to for ibc migrator


can you explain?

oren-lava · 2025-01-28T15:52:43Z

cmd/lavad/cmd/root.go

 		authcmd.QueryTxsByEventsCmd(),
 		authcmd.QueryTxCmd(),
 	)

-	app.ModuleBasics.AddQueryCommands(cmd)
+	moduleBasics.AddQueryCommands(cmd)


can be removed (https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#autocli)

oren-lava · 2025-01-28T15:53:10Z

cmd/lavad/cmd/root.go

@@ -306,7 +346,7 @@ func txCommand() *cobra.Command {
 		authcmd.GetDecodeCommand(),
 	)

-	app.ModuleBasics.AddTxCommands(cmd)
+	moduleBasics.AddTxCommands(cmd)


can be removed (https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#autocli)

oren-lava · 2025-01-28T16:04:43Z

Should we consider these?

grpc-web port: https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#grpc-web-1
all GetTxCmd() and GetQueryCmd() can be removed (https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#all-1)
all AddTxCommands() and AddQueryCommands() can be removed (https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#autocli)

Yarom Swisa added 22 commits November 25, 2024 11:03

WIP

5d37557

fix errors in app.go

aed37e0

WIP

a5b90c8

WIP

6a31f54

fix all bond denom

3bdc6ae

WIP

cd2a8d5

update proto files types

a598996

WIP

88e9c23

remove legacy handlers

a03db32

WIP

ca91754

fix simulations

6dc16a4

fix simulations

fb3ee7b

fix equal method for coins

c9b14b1

WIP

f2f47ef

WIP

e48f10c

mock keepers

c2e0613

fix test keepers

52e10b9

tidy

9fa7393

remove the use of "core"

6156c2b

module basic

2c5c1b1

lint

29345bd

add auto cli

ab7c0f3

github-actions bot added C:protocol Team:Protocol Team:Consensus C:x/protocol C:x/dualstaking C:x/epochstorage C:x/pairing C:cmd/lavad labels Dec 12, 2024

Yarom Swisa added 3 commits December 15, 2024 16:53

Merge branch 'main' into CNS-cosmos-50-upgrade

4316577

generate protobufs

70898dc

Revert "remove addquery/txcommands"

b01ea2b

This reverts commit 6b55d8c.

TODOs

97087ee

shleikes assigned Yaroms Dec 16, 2024

Yarom Swisa added 2 commits December 16, 2024 17:17

Merge branch 'main' into CNS-cosmos-50-upgrade

2d9987e

make sort specs onchain

67c7f0b

github-actions bot added the C:cookbook label Dec 16, 2024

Yarom Swisa and others added 17 commits January 5, 2025 11:41

Merge branch 'main' into CNS-cosmos-50-upgrade

61b67d8

fix

15cebc5

fix test

dbae8b8

init mock account keeper for test

f1f638d

Merge branch 'main' into CNS-cosmos-50-upgrade

fed14ec

Revert "make sort specs onchain"

35384f7

This reverts commit 67c7f0b.

Merge branch 'CNS-cosmos-50-upgrade' of github.com:lavanet/lava into …

eafa763

…CNS-cosmos-50-upgrade

make sure to run init of config for tests

cd9aeb0

add moniker and min to new validator in tests

5e35ff8

try to fix relay_payment decode

98fcb54

Merge branch 'main' into CNS-cosmos-50-upgrade

e17f19a

Merge branch 'main' into CNS-cosmos-50-upgrade

9f44b14

run init config for e2e

fd30293

Merge branch 'CNS-cosmos-50-upgrade' of github.com:lavanet/lava into …

a5f9817

…CNS-cosmos-50-upgrade

Revert "try to fix relay_payment decode"

6b7a983

This reverts commit 98fcb54.

add log

e037355

fix build relay payment event, now we only consider attributes with "."

18a9c09

oren-lava requested changes Jan 28, 2025

View reviewed changes

oren-lava reviewed Jan 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade to cosmos v50 #1833

feat: upgrade to cosmos v50 #1833

Yaroms commented Dec 12, 2024

github-actions bot commented Dec 15, 2024 •

edited

Loading

oren-lava Jan 28, 2025

oren-lava Jan 28, 2025

oren-lava Jan 28, 2025

oren-lava Jan 28, 2025

oren-lava Jan 28, 2025

oren-lava Jan 28, 2025

oren-lava Jan 28, 2025

oren-lava Jan 28, 2025

oren-lava Jan 28, 2025

oren-lava Jan 28, 2025

oren-lava Jan 28, 2025

oren-lava Jan 28, 2025

oren-lava commented Jan 28, 2025


		return nil
		return k.distributionKeeper.SetFeePool(ctx, feePool)

feat: upgrade to cosmos v50 #1833

Are you sure you want to change the base?

feat: upgrade to cosmos v50 #1833

Conversation

Yaroms commented Dec 12, 2024

Description

Author Checklist

Reviewers Checklist

github-actions bot commented Dec 15, 2024 • edited Loading

Test Results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oren-lava commented Jan 28, 2025

github-actions bot commented Dec 15, 2024 •

edited

Loading