Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sonic spec #1963

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add sonic spec #1963

wants to merge 1 commit into from

Conversation

oren-lava
Copy link
Collaborator

Description

Closes: #XXXX

Added Sonic (previously Fantom) spec. This will be a separate spec until Fantom is completely not supported


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@oren-lava oren-lava requested a review from Yaroms February 13, 2025 12:10
@oren-lava oren-lava self-assigned this Feb 13, 2025
Copy link

Test Results

2 519 tests  ±0   2 518 ✅ ±0   25m 18s ⏱️ - 2m 1s
  124 suites ±0       1 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 362c54e. ± Comparison against base commit 5e4b420.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants