feat: directory mounting supports bind and volume modes

[DDSDerek]

fix #121

@lavie

[lavie]

Thanks.

Why must we add :rw when it's the default?
https://docs.docker.com/engine/storage/volumes/#options-for---volume

Similarly, we add a : prefix when the volume name is omitted, which means we can no longer generate a clean-looking 'run --volume some_path`, which is what the test fixture actually uses.

I prefer to default to the cleanest syntax, even though it's less explicit, because otherwise even a seemingly simple container ends up having tons of options in its run command just because they're all default values.

[DDSDerek]

Thanks.

Why must we add :rw when it's the default? https://docs.docker.com/engine/storage/volumes/#options-for---volume

Similarly, we add a : prefix when the volume name is omitted, which means we can no longer generate a clean-looking 'run --volume some_path`, which is what the test fixture actually uses.

I prefer to default to the cleanest syntax, even though it's less explicit, because otherwise even a seemingly simple container ends up having tons of options in its run command just because they're all default values.

Thanks for pointing that out, I've made the changes in 6c2a4b1.
Only add :ro if the user specifies read-only mount.
Don't add it for the default case.
And added a test unit to deal with the situation where the user specifies to use read-only mode.

[lavie]

Appreciated! Could I also ask you to please omit the source/name and the : completely in case they are empty/unspecified?
So we could have run -v /mount instead of run -v :/mount

[DDSDerek]

Appreciated! Could I also ask you to please omit the source/name and the : completely in case they are empty/unspecified? So we could have run -v /mount instead of run -v :/mount

For this situation, there is a solution in #115 (comment)

[DDSDerek]

Appreciated! Could I also ask you to please omit the source/name and the : completely in case they are empty/unspecified? So we could have run -v /mount instead of run -v :/mount

I added the -use-volume-id parameter to let users choose whether to use the volume automatically allocated by Docker.
By default, it is not used, which is consistent with the current state.

[DDSDerek]

I hope you can review it again and point out if there are any problems.