Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Site manager #417

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

fetzerms
Copy link
Contributor

These commits add a site manager to lftp. This site manager is similar to bookmarks, but (for now)
allows to take notes, set local and remote paths. This is a first initial working version. More features
might be added later.

@fetzerms
Copy link
Contributor Author

I am pretty sure, that src/Makefile.am is not "correct". Can anyone help me to include json-c properly?

@fetzerms
Copy link
Contributor Author

@lavv17 What do you think about this feature? I am open to any comments/additions etc.

@lavv17
Copy link
Owner

lavv17 commented Nov 27, 2017

Not bad, but why limit this site manager with ftp and ftps only? Can it store any URL instead?

@fetzerms
Copy link
Contributor Author

There was no specific reason for this. I think we can have it store any url and/or protocol.
Actually i'm not sure if and how the concept of "local path", "remote path" etc applies to
other protocols.

@fetzerms
Copy link
Contributor Author

Maybe we should just have a parameter for "Protocol" and store (ftp, sftp, ftps,...) in there.
How would this work for torrent? Or is torrent excluded from open-command anyways?

@lavv17
Copy link
Owner

lavv17 commented Nov 28, 2017

Maybe it is better to extend "bookmark" with a note and ability to change local path. The file format can be changed (upgraded automatically with a new name).

@fetzerms
Copy link
Contributor Author

I was having other features in mind aswell, such as "execute the following commands upon connect" and such. But yes - this would (in the best case) be a complete replacement for "bookmark", which allows for more sophisticated use of bookmarks.

Currently I use Json as a file format, as it is easy to serialize / deserialize. How should we progress?

@fetzerms
Copy link
Contributor Author

fetzerms commented Dec 12, 2017

@lavv17 What do you think? Should I implement a replacement for bookmark? Tho i think it can be rather some sort of additional feature. I could even imagine a bookmark-per-site bookmark-style.

@lavv17
Copy link
Owner

lavv17 commented Dec 22, 2017

Currently the bookmark command can also execute commands upon connect, just add -e option with commands after the url. But it lacks any comments. For serialization you can also try to use Bencode, it's already there in lftp, used in torrent.

@fetzerms
Copy link
Contributor Author

Getting back to this one:

I thought about implementing this one further. Including proxy-per-site, epsv addr per site and bookmarks (directories) for the saves sites as well. I don't think that I can achieve those things (properly) while using the current bookmark feature.

I fiddled a little with Bencode, which seems to do its job fine. Tho a more portable format (such as Json and/or Xml) would be prefered from my side. Then one could use third party tools to read and/or organize the sites as well.

@fetzerms
Copy link
Contributor Author

The proxy support is little broken as of now - But I do not assume that there (currently) is a chance of a merge anyways. I will keep developing that feature further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants