Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace symlink after removing previous symlink #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjwoods
Copy link

@mjwoods mjwoods commented Jun 26, 2018

Resolves issue #456.

With this change, mirror -R can replace symlinks over sftp.

One side-effect is that ln -s will also replace symlinks, when this would normally be an error.

A better solution would allow mirror -R to replace symlinks without changing the behaviour of ln -s. Any suggestions?

@mjwoods
Copy link
Author

mjwoods commented Jun 29, 2018

The travis-ci build failure seems unrelated to the changes in this PR. The error indicates a missing header file, as follows:

module.cc:30:24: fatal error: configmake.h: No such file or directory

@lavv17
Copy link
Owner

lavv17 commented Jul 9, 2018

I don't like removing the old file without knowing it's a symlink first. Mirror should itself remove the old symlink if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants