Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if pyodide fails, then parse with the server #2350

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

longhotsummer
Copy link
Contributor

@longhotsummer longhotsummer commented Feb 7, 2025

This will handle an unexpected failure in python (eg. a memory error) by falling back to server-side parsing.

If the parse fails because the grammar is not matched, it's still shown as an error.

Copy link

github-actions bot commented Feb 7, 2025

Test Results

569 tests  ±0   569 ✅ ±0   4m 37s ⏱️ +10s
 60 suites ±0     0 💤 ±0 
 60 files   ±0     0 ❌ ±0 

Results for commit ea6e58d. ± Comparison against base commit 32ae19d.

♻️ This comment has been updated with latest results.

@goose-life
Copy link
Contributor

neat!

@longhotsummer longhotsummer merged commit e67af06 into master Feb 10, 2025
5 checks passed
@longhotsummer longhotsummer deleted the bluebell-error branch February 10, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants