Handle refs to schedules #2354
Merged
Handle refs to schedules #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goose-life
reviewed
Feb 10, 2025
| @@ -361,7 +397,8 @@ class ProvisionRefsMatcher(CitationMatcher): | |||
|
|
|||
| # this just finds the start of a potential match, the grammar looks for the rest | |||
| pattern_names = '|'.join(ProvisionRefsResolver.element_names.keys()) | |||
| pattern_re = re.compile(fr'\b({pattern_names})\s+(\d|\([a-z0-9])', re.IGNORECASE) | |||
| the_schedule_patterns = '|'.join(['the schedule', 'die bylaag']) | |||
There was a problem hiding this comment.
is the French missing here, or how does this part fit in?
There was a problem hiding this comment.
we don't currently support french at all when doing lookups - only the grammar supports it. I don't want to change that with this PR.
goose-life
previously approved these changes
Feb 10, 2025
goose-life
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles:
Does not handle:
It works by looking for an
<attachment>with an exact match on<heading>.