Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve diff navigation #2358

Merged
merged 3 commits into from
Feb 13, 2025
Merged

improve diff navigation #2358

merged 3 commits into from
Feb 13, 2025

Conversation

longhotsummer
Copy link
Contributor

@longhotsummer longhotsummer commented Feb 12, 2025

  • show current and total changes (eg. "1 / 2")
  • treat diff-pairs (del + ins) as a single item
  • when scrolling to the item, put it 3em below the top of the scroll container

image

diff pairs

Treat <del>(a)</del><a class="ins akn-ref" href="#foo>(a)</a> as a diff pair

before:

Image 2025-02-12 21-46-05

image

after:

image

image

Copy link

github-actions bot commented Feb 12, 2025

Test Results

579 tests  ±0   579 ✅ ±0   4m 36s ⏱️ +8s
 60 suites ±0     0 💤 ±0 
 60 files   ±0     0 ❌ ±0 

Results for commit e05313d. ± Comparison against base commit 46a971c.

♻️ This comment has been updated with latest results.

this makes the common case of "(a)" being turned into a link
"<ref>(a)</ref>" work better as a diff pair
@goose-life
Copy link
Contributor

treat diff-pairs (del + ins) as a single item

🙌 🙌 🙌

@longhotsummer longhotsummer merged commit cb9a05a into master Feb 13, 2025
5 checks passed
@longhotsummer longhotsummer deleted the diffs branch February 13, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants