[LPDC-1277] Add modal popup to see existing instances before creating new one #19
Conversation
| @@ -152,14 +152,12 @@ | |||
| {{else if this.hasResults}} | |||
| <Content.body as |concept|> | |||
| <td> | |||
| <AuLink | |||
| @route="public-services.concept-details" | |||
There was a problem hiding this comment.
It seems it's now no longer possible to preview a concept before creating an instance. Was that an intentional change?
if we want to skip the preview, I think that only makes sense for concepts that are already instantiated? So we could conditionally show the preview link if there are no instances yet, or the button that triggers the modal if there are already some instances.
I think it make more sense to simply redirect to the preview page from the modal though, but maybe double check with the design team. Or move the modal to the preview page instead.
There was a problem hiding this comment.
It was indeed an oversight, I wasn't sure what it did. I've added the preview back in
There was a problem hiding this comment.
I would do it conditionally here, instead of in the modal. That way the API call in the modal doesn't need to happen when it isn't needed and links are generally better because users can open those in new tabs if they want.
But I'm still not convinced we should display the modal here (or a modal at all). I think it might be better to update the details preview page instead, but again, ideally this would get looked at by the design team..
There was a problem hiding this comment.
I'm not sure why but the isInstantiated doesn't seem to be accurate, some of the instances are displayed correctly but some are not..
There was a problem hiding this comment.
Hmm, that's a bigger problem then. I can't remember how that part works exactly, or where it's updated. But that would also mean that users would see the modal even if there is no "toegevoegd" label next to the concept. 🤔
There was a problem hiding this comment.
Yes indeed, I have not really used the app before so I'm not sure if I'm missing something (maybe it needs some time to update?)
| }, | ||
| }); | ||
| } else { | ||
| this.createPublicService.perform(conceptId); |
There was a problem hiding this comment.
I don't think we want to do this without showing the user the preview first? Also, if we check the concept.displayConfiguration.isInstantiated flag in the template before displaying the modal button, this else block should never be reached.
There was a problem hiding this comment.
Not sure what you mean with this, but I've added the preview queryParam
| <span class="au-u-h4 au-u-medium">Bestaande instanties</span> | ||
| {{#each @data.existingInstances as |instance|}} | ||
| <p> | ||
| <AuLink class="au-u-margin-right" @route="public-services.details" @model={{instance.id}} @query={{hash | ||
| preview=true}} {{on "click" this.close}}> | ||
| {{instance.nameNl}} | ||
| </AuLink> | ||
| gewijzigd op ({{moment-format instance.dateModified "DD-MM-YYYY - HH:mm"}}) | ||
| </p> | ||
| {{/each}} |
There was a problem hiding this comment.
I think an <AuTable> component might look better here:
https://appuniversum.github.io/ember-appuniversum/?path=/story/components-tables-autable--component
| <AuButton class="au-u-margin-top au-u-padding-none" @skin="link" @disabled={{this.createNewInstance.isRunning}} | ||
| @loading={{this.createNewInstance.isRunning}} @loadingMessage="Nieuwe instantie aan het aanmaken" {{on "click" | ||
| (perform this.createNewInstance)}}> | ||
| Nieuwe instantie maken | ||
| </AuButton> |
There was a problem hiding this comment.
I know this was discussed in the Jira issue, but I would double check with the UX team. It feels like an anti-pattern to make things "less obvious" on purpose to discourage the use of it.
It just looks weird to me at the moment.
ID
LPDC-1277
Description
Add modal popup to warn the user when they are about to create an instance that already exists, show the existing instances so the user can consolidate them.
How to test
Product of dienst toevoegenbutton