[Merged by Bors] - fix: comment more cache #17491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary e7ecd9d586Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
github-actions
bot
added
the
CI
|
Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
The previous fix was an improvement, but was not aggressive enough in commenting the failing step. This step used to use `cache` to download the cache for `Mathlib.Init`. If this was successful, then it would continue trying to download all of the available cache. Otherwise, it would start with building. The underlying reason is that if even the cache for `Mathlib.Init` is not there, there is not much of an available cache and there is no need to spend a couple of minutes realizing as much. However, changes to `lake build --no-buld` (possibly) have made this step always fail to download any cache, so we revert to the old behaviour of trying to get the cache no matter what.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
|
cc: @tydeu so he is aware of this issue |
|
@digama0 This was discussed on Zulip and a fix was implemented in leanprover/lean4#5641. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
This check had been removed (cf #17490 and #17491) since it stopped working temporarily. It seems that it works again! 🐙 (According to a comment on #17491, the fix was apparently in leanprover/lean4#5641)
TobiasLeichtfried
pushed a commit
that referenced
this pull request
Nov 21, 2024
This check had been removed (cf #17490 and #17491) since it stopped working temporarily. It seems that it works again! 🐙 (According to a comment on #17491, the fix was apparently in leanprover/lean4#5641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix was an improvement, but was not aggressive enough in commenting the failing step.
This step used to use
cacheto download the cache forMathlib.Init. If this was successful, then it would continue trying to download all of the available cache. Otherwise, it would start with building. The underlying reason is that if even the cache forMathlib.Initis not there, there is not much of an available cache and there is no need to spend a couple of minutes realizing as much.However, changes to
lake build --no-buld(possibly) have made this step always fail to download any cache, so we revert to the old behaviour of trying to get the cache no matter what.