Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AlgebraicGeometry): API for zero locus #20812

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jan 17, 2025


Open in Gitpod

Copy link

github-actions bot commented Jan 17, 2025

PR summary 00eb1b0832

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsAffineOpen.fromSpec_image_zeroLocus
+ IsAffineOpen.fromSpec_preimage_zeroLocus
+ Opens.toSpecΓ_preimage_zeroLocus
+ Scheme.Opens.toSpecΓ_appTop
+ Scheme.isoSpec_inv_toSpecΓ
+ Scheme.toSpecΓ_isoSpec_inv
+ Scheme.zeroLocus_biInf
+ Scheme.zeroLocus_biInf_of_nonempty
+ Scheme.zeroLocus_iInf
+ Scheme.zeroLocus_iInf_of_nonempty
+ Scheme.zeroLocus_inf
+ Spec_zeroLocus
+ Spec_zeroLocus_eq_zeroLocus
+ basicOpen_add_le
+ basicOpen_one
+ codisjoint_iff_compl_le_left
+ codisjoint_iff_compl_le_right
+ codisjoint_zeroLocus
+ eq_zeroLocus_of_isClosed_of_isAffine
+ image_zeroLocus
+ isoSpec_image_zeroLocus
+ isoSpec_inv_image_zeroLocus
+ isoSpec_inv_preimage_zeroLocus
+ isoSpec_inv_toSpecΓ
+ map_mem_image_iff
+ mem_bot
+ mem_inf
+ preimage_zeroLocus
+ toSpecΓ_fromSpec
+ toSpecΓ_image_zeroLocus
+ toSpecΓ_isoSpec_inv
+ toSpecΓ_preimage_zeroLocus
+ toΓSpec_image_zeroLocus_eq_of_isAffine
+ toΓSpec_preimage_zeroLocus_eq
+ zeroLocus_map
+ zeroLocus_map_of_eq
+ zeroLocus_mono
+ zeroLocus_span
+ zeroLocus_univ
- Scheme.eq_zeroLocus_of_isClosed_of_isAffine
- Scheme.toΓSpec_image_zeroLocus_eq_of_isAffine
- Scheme.toΓSpec_preimage_zeroLocus_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
1415 1 erw

Current commit 00eb1b0832
Reference commit 3830035266

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@erdOne erdOne added the t-algebraic-geometry Algebraic geometry label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebraic-geometry Algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant