Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: address some porting notes in Mathlib/Computability #20822

Closed
wants to merge 4 commits into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Jan 18, 2025


Open in Gitpod

Copy link

github-actions bot commented Jan 18, 2025

PR summary 42ce77b922

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ sectionΓ'Bool_inclusionBoolΓ'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (7.57, 0.04)
Current number Change Type
4597 -21 porting notes
194 -7 disabled simpNF lints

Current commit 42ce77b922
Reference commit a4c5ecf11c

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg added porting-notes Mathlib3 to Mathlib4 porting notes. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Jan 18, 2025
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer delegate

Mathlib/Computability/Encoding.lean Show resolved Hide resolved
Mathlib/Computability/Encoding.lean Show resolved Hide resolved
Mathlib/Computability/Language.lean Outdated Show resolved Hide resolved
Mathlib/Computability/PartrecCode.lean Show resolved Hide resolved
Mathlib/Computability/RegularExpressions.lean Outdated Show resolved Hide resolved
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@grunweg grunweg added the t-computability Computability theory (TMs, DFAs, languages, grammars, etc) label Jan 18, 2025
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 18, 2025

✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kim-em
Copy link
Contributor Author

kim-em commented Jan 21, 2025

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 21, 2025

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 21, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: address some porting notes in Mathlib/Computability [Merged by Bors] - chore: address some porting notes in Mathlib/Computability Jan 21, 2025
@mathlib-bors mathlib-bors bot closed this Jan 21, 2025
@mathlib-bors mathlib-bors bot deleted the computability_porting_notes branch January 21, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated maintainer-merge porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors. t-computability Computability theory (TMs, DFAs, languages, grammars, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants