chore: make sure simp_rw uses each lemma #5770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kim-em
commented
Jul 8, 2023
kim-em
commented
eric-wieser
reviewed
Jul 8, 2023
| @@ -59,6 +60,6 @@ elab s:"simp_rw " rws:rwRuleSeq g:(location)? : tactic => do | |||
| evalTactic (← match term with | |||
| | `(term| $e:term) => | |||
| if symm then | |||
| `(tactic| simp%$e only [←$e:term] $g ?) | |||
| `(tactic| fail_if_no_progress simp%$e only [←$e:term] $g ?) | |||
There was a problem hiding this comment.
Is it possible to make this just a warning on the unused lemma, as I think happens in simp?
There was a problem hiding this comment.
Yes, a warning would be better.
In any case this PR isn't viable, it will require #3757 first.
|
Is this a duplicate of #3782? |
Thanks, yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.