Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion for tactics #1651

Closed
digama0 opened this issue Sep 26, 2022 · 1 comment · Fixed by #5666
Closed

Completion for tactics #1651

digama0 opened this issue Sep 26, 2022 · 1 comment · Fixed by #5666
Labels
server Affects the Lean server code

Comments

@digama0
Copy link
Collaborator

digama0 commented Sep 26, 2022 •
edited
Loading

easy:

example : 1 + 1 = 2 := by
  sim
   --^ textDocument/completion

harder:

example : 1 + 1 = 2 := by
  skip
  
--^ textDocument/completion
  done

hardest:

example : 1 + 1 = 2 := by
  
--^ textDocument/completion
@leodemoura
Copy link
Member

Only the easy case is currently implemented.

@mhuisi mhuisi added the server Affects the Lean server code label Sep 5, 2023
@mhuisi mhuisi mentioned this issue Oct 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2024
@mhuisi
feat: whitespace tactic completion & tactic completion docs (#5666)
3930100 
This PR enables tactic completion in the whitespace of a tactic proof
and adds tactic docstrings to the completion menu.

Future work:
- A couple of broken tactic completions: This is due to tactic
completion now using @david-christiansen's `Tactic.Doc.allTacticDocs` to
obtain the tactic docstrings and should be fixed soon.
- Whitespace tactic completion in tactic combinators: This requires
changing the syntax of tactic combinators to produce a syntax node that
makes it clear that a tactic is expected at the given position.

Closes #1651.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
server Affects the Lean server code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: whitespace tactic completion & tactic completion docs mhuisi/lean4
3 participants
@digama0 @leodemoura @mhuisi