Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: whitespace tactic completion & tactic completion docs #5666

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

mhuisi
Copy link
Contributor

@mhuisi mhuisi commented Oct 10, 2024

This PR enables tactic completion in the whitespace of a tactic proof and adds tactic docstrings to the completion menu.

Future work:

  • A couple of broken tactic completions: This is due to tactic completion now using @david-christiansen's Tactic.Doc.allTacticDocs to obtain the tactic docstrings and should be fixed soon.
  • Whitespace tactic completion in tactic combinators: This requires changing the syntax of tactic combinators to produce a syntax node that makes it clear that a tactic is expected at the given position.

Closes #1651.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 10, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-10-10 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-10-10 09:31:02)

@mhuisi mhuisi added this pull request to the merge queue Oct 10, 2024
Merged via the queue into leanprover:master with commit 3930100 Oct 10, 2024
14 checks passed
@mhuisi mhuisi deleted the mhuis/tactic-completion branch October 10, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion for tactics
2 participants